Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kimwnasptd to github org #56

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Add kimwnasptd to github org #56

merged 1 commit into from
Feb 5, 2019

Conversation

kimwnasptd
Copy link
Member

@kimwnasptd kimwnasptd commented Feb 1, 2019 •
edited by jlewi
Loading

some contributions I'm trying to make:
#PR1
#PR2

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @kimwnasptd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Feb 5, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45199ef into kubeflow:master Feb 5, 2019
@kimwnasptd kimwnasptd deleted the add_kimwnasptd branch February 5, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-g abhi-g Awaiting requested review from abhi-g

@theadactyl theadactyl Awaiting requested review from theadactyl

Assignees

@jlewi jlewi

Labels
approved lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimwnasptd @k8s-ci-robot @jlewi