Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alembiewski to the members list #553

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Add alembiewski to the members list #553

merged 2 commits into from
Jun 22, 2022

Conversation

alembiewski
Copy link
Member

This PR adds me to the Kubeflow member list.

✅ Provide 2-3 links to PRs or other contributions
kubeflow/kubeflow#6494
kubeflow/kubeflow#6406
kubeflow/training-operator#1541
kubeflow/training-operator#1437
kubeflow/training-operator#1420
kubeflow/training-operator#1283
kubeflow/pipelines#7862
kubeflow/pipelines#4951

✅ List 2 existing members who are sponsoring your membership.
@gaocegege
@kimwnasptd

✅ Test your PR by running the following:

$ git rev-parse --short HEAD
d3142cf
$ pytest test_org_yaml.py
============================================================================================= test session starts ==============================================================================================
platform darwin -- Python 3.7.3, pytest-6.1.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/alembiyeuski/go/src/github.com/mesosphere/internal-acls/github-orgs
plugins: hypothesis-6.14.5, anyio-3.5.0
collected 1 item

test_org_yaml.py .                                                                                                                                                                                       [100%]

============================================================================================== 1 passed in 0.36s ===============================================================================================

@google-oss-prow google-oss-prow bot requested review from chensun and zijianjoy June 16, 2022 11:52
@google-oss-prow
Copy link

Hi @alembiewski. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kimwnasptd
Copy link
Member

/lgtm

Thank you for your contributions!

@google-oss-prow google-oss-prow bot added the lgtm label Jun 17, 2022
@gaocegege
Copy link
Member

/lgtm

Thanks for your awesome contribution!

Arhell
Arhell reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

zijianjoy
zijianjoy reviewed Jun 21, 2022
View reviewed changes
github-orgs/kubeflow/org.yaml Outdated
@@ -38,6 +38,7 @@ orgs:
- alculquicondor
- alexlatchford
- alexmt
- alembiewski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Can you order the position of your user name by alphabetic order? (Move your name to two lines above)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@google-oss-prow google-oss-prow bot removed the lgtm label Jun 21, 2022
@gaocegege
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 21, 2022
@zijianjoy
Copy link
Contributor

/lgtm
/approve

Welcome to the community!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alembiewski, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a7c8f96 into kubeflow:master Jun 22, 2022
zijianjoy pushed a commit to zijianjoy/internal-acls that referenced this pull request Oct 25, 2022
@alembiewski @zijianjoy
Add alembiewski to the members list (kubeflow#553)
268f4c1 
* Add alembiewski to the members list

* Fix the ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijianjoy zijianjoy zijianjoy left review comments

@Arhell Arhell Arhell left review comments

@chensun chensun Awaiting requested review from chensun

Assignees

@gaocegege gaocegege

@kimwnasptd kimwnasptd

@zijianjoy zijianjoy

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alembiewski @kimwnasptd @gaocegege @zijianjoy @Arhell