[#448] Add -Wnoncanonical-monad-instances (#516)

* [#448] Add -Wnoncanonical-monad-instances * [#448] Add new warning to README
kowainik · Oct 26, 2020 · b56aada · b56aada
1 parent d2ab6bd
commit b56aada
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -135,6 +135,7 @@ Features related to the structure and content of the generated projects.
   -Wincomplete-uni-patterns
   -Wincomplete-record-updates
   -Wredundant-constraints
+  -Wnoncanonical-monad-instances
   -fhide-source-paths           (GHC ⩾ 8.2)
   -Wmissing-export-lists        (GHC ⩾ 8.4)
   -Wpartial-fields              (GHC ⩾ 8.4)

diff --git a/summoner-cli/examples/cabal-full/cabal-full.cabal b/summoner-cli/examples/cabal-full/cabal-full.cabal
@@ -38,6 +38,7 @@ common common-options
                        -Wincomplete-uni-patterns
                        -Wincomplete-record-updates
                        -Wredundant-constraints
+                       -Wnoncanonical-monad-instances
   if impl(ghc >= 8.2)
     ghc-options:       -fhide-source-paths
   if impl(ghc >= 8.4)

diff --git a/summoner-cli/examples/cabal-minimal/cabal-minimal.cabal b/summoner-cli/examples/cabal-minimal/cabal-minimal.cabal
@@ -23,6 +23,7 @@ common common-options
                        -Wincomplete-uni-patterns
                        -Wincomplete-record-updates
                        -Wredundant-constraints
+                       -Wnoncanonical-monad-instances
   if impl(ghc >= 8.2)
     ghc-options:       -fhide-source-paths
   if impl(ghc >= 8.4)

diff --git a/summoner-cli/examples/stack-full/stack-full.cabal b/summoner-cli/examples/stack-full/stack-full.cabal
@@ -38,6 +38,7 @@ common common-options
                        -Wincomplete-uni-patterns
                        -Wincomplete-record-updates
                        -Wredundant-constraints
+                       -Wnoncanonical-monad-instances
   if impl(ghc >= 8.2)
     ghc-options:       -fhide-source-paths
   if impl(ghc >= 8.4)

diff --git a/summoner-cli/src/Summoner/Template/Cabal.hs b/summoner-cli/src/Summoner/Template/Cabal.hs
@@ -132,6 +132,7 @@ cabalFile Settings{..} = File (toString settingsRepo ++ ".cabal") cabalFileConte
         , "                       -Wincomplete-uni-patterns"
         , "                       -Wincomplete-record-updates"
         , "                       -Wredundant-constraints"
+        , "                       -Wnoncanonical-monad-instances"
         , "  if impl(ghc >= 8.2)"
         , "    ghc-options:       -fhide-source-paths"
         , "  if impl(ghc >= 8.4)"

diff --git a/summoner-cli/summoner.cabal b/summoner-cli/summoner.cabal
@@ -85,12 +85,10 @@ common common-options
                        -Widentities
                        -Wincomplete-uni-patterns
                        -Wincomplete-record-updates
-  if impl(ghc >= 8.0)
-    ghc-options:       -Wredundant-constraints
-  if impl(ghc >= 8.2)
-    ghc-options:       -fhide-source-paths
-  if impl(ghc >= 8.4)
-    ghc-options:       -Wmissing-export-lists
+                       -Wredundant-constraints
+                       -Wnoncanonical-monad-instances
+                       -fhide-source-paths
+                       -Wmissing-export-lists
                        -Wpartial-fields
   if impl(ghc >= 8.8)
     ghc-options:       -Wmissing-deriving-strategies

diff --git a/summoner-tui/summoner-tui.cabal b/summoner-tui/summoner-tui.cabal
@@ -38,12 +38,10 @@ common common-options
                        -Widentities
                        -Wincomplete-uni-patterns
                        -Wincomplete-record-updates
-  if impl(ghc >= 8.0)
-    ghc-options:       -Wredundant-constraints
-  if impl(ghc >= 8.2)
-    ghc-options:       -fhide-source-paths
-  if impl(ghc >= 8.4)
-    ghc-options:       -Wmissing-export-lists
+                       -Wredundant-constraints
+                       -Wnoncanonical-monad-instances
+                       -fhide-source-paths
+                       -Wmissing-export-lists
                        -Wpartial-fields
   if impl(ghc >= 8.8)
     ghc-options:       -Wmissing-deriving-strategies