feat: use knative operator overrides (#25)

koor-tech · Mar 16, 2024 · b12e899 · b12e899
1 parent d396516
commit b12e899
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 9 deletions.
diff --git a/exp/knative-basic/README.md b/exp/knative-basic/README.md
@@ -10,10 +10,6 @@ This could be intermediate files in your image processing pipeline or [find appl
 ```bash
 kubectl apply -f deploy/operator.yaml
 kubectl apply -f deploy/serving.yaml
-kubectl patch service/kourier \
-    -n knative-serving \
-    --type merge -p '{"metadata": {"annotations": {"load-balancer.hetzner.cloud/name": "koor-demo-staging-kourier" }}}'
-
 ```
 
 ## Install knative func

diff --git a/exp/knative-basic/deploy/serving.yaml b/exp/knative-basic/deploy/serving.yaml
@@ -21,4 +21,11 @@ spec:
     features:
       kubernetes.podspec-persistent-volume-claim: "enabled"
       kubernetes.podspec-persistent-volume-write: "enabled"
-      kubernetes.podspec-securitycontext: "enabled"
+      kubernetes.podspec-securitycontext: "enabled"
+  services:
+    - name: kourier
+      # Override annotations for the kourier service
+      annotations:
+        # A provider-specific annotation is necessary to access the functions using a load balancer
+        # For Hetzner it is:
+        load-balancer.hetzner.cloud/name: "koor-demo-kourier"
diff --git a/exp/knative-ml/README.md b/exp/knative-ml/README.md
@@ -20,9 +20,6 @@ kubectl rook-ceph ceph status
 ```bash
 kubectl apply -f deploy/operator.yaml
 kubectl apply -f deploy/serving.yaml
-kubectl patch service/kourier \
-    -n knative-serving \
-    --type merge -p '{"metadata": {"annotations": {"load-balancer.hetzner.cloud/name": "koor-demo-kourier" }}}'
 kubectl apply -f deploy/eventing.yaml
 
 ```

diff --git a/exp/knative-ml/deploy/serving.yaml b/exp/knative-ml/deploy/serving.yaml
@@ -19,4 +19,11 @@ spec:
     domain:
       "knative.koor.dev": ""
     network:
-      ingress-class: "kourier.ingress.networking.knative.dev"
+      ingress-class: "kourier.ingress.networking.knative.dev"
+  services:
+    - name: kourier
+      # Override annotations for the kourier service
+      annotations:
+        # A provider-specific annotation is necessary to access the functions using a load balancer
+        # For Hetzner it is:
+        load-balancer.hetzner.cloud/name: "koor-demo-kourier"