Support change to ERC-681

I disagree with this change though - so only make it so we *can* parse it - but not really exposing it. I really hope this change gets taken back. Context: ethereum/EIPs#681 (comment)
komputing · May 13, 2019 · f86d420 · f86d420
1 parent e429716
commit f86d420
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/erc681/src/main/kotlin/org/kethereum/erc681/ERC681Parser.kt b/erc681/src/main/kotlin/org/kethereum/erc681/ERC681Parser.kt
@@ -49,7 +49,7 @@ fun CommonEthereumURIData.toERC681() = let { commonURI ->
         val queryAsMap = commonURI.query.toMap() // should be improved https://github.com/walleth/kethereum/issues/25
 
         gas = queryAsMap["gas"].toBigInteger()
-        value = queryAsMap["value"].toBigInteger()
+        value = queryAsMap["value"]?.split("-")?.first()?.toBigInteger()
 
         functionParams = commonURI.query.filter { it.first != "gas" && it.first != "value" }
     }

diff --git a/erc681/src/test/kotlin/org/kethereum/erc681/TheERC681Parsing.kt b/erc681/src/test/kotlin/org/kethereum/erc681/TheERC681Parsing.kt
@@ -138,4 +138,9 @@ class TheERC681Parsing {
     fun weDoNotStumbleUponIllegal681() {
         Assertions.assertThat(parseERC681("ethereum:pay-0x00AB42@23?value=42.42").valid).isEqualTo(false)
     }
+
+    @Test
+    fun testSupportsValueSuffix() {
+        Assertions.assertThat(parseERC681("ethereum:pay-0x00AB42@23?value=42-ETH").valid).isEqualTo(true)
+    }
 }