fix: Misleading Withdraw Amount wording in Offers
#11239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hassnian
changed the title
Withdraw Amount wording in Offers
hassnian
requested review from
preschian and
Jarsen136
and removed request for
a team
|
|
missing review @Jarsen136 |
Mainly text adjustment |
Jarsen136
approved these changes
Dec 16, 2024
|
looks good! thank you |
exezbcz
approved these changes
Dec 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Context
❗️pls don't merge without @exezbcz 's green light
if the trade is active:
Cancel Offer/Swapif the trade is expired:
Withdraw Amounthas been changed toWithdraw Offer/Swap, should this also be red ?Withdraw Amountwording in Offers #11237Screenshot 📸
QA
CleanShot.2024-12-11.at.11.31.59.mp4
CleanShot.2024-12-11.at.11.29.40.mp4