Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciler for Knative Certificate #3475

Merged
merged 41 commits into from
May 8, 2019
Merged

Reconciler for Knative Certificate #3475

merged 41 commits into from
May 8, 2019

Conversation

ZhiminXiang
Copy link

Fixes #
#3051

Proposed Changes

  • Implement the reconciler for Knative Certificate which essentially reconciles Cert-Manager Certificate to request TLS certificates.
  • Add a ConfigMap config-certmanager to configure the Cert-Manager Certificate

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers area/networking labels Mar 21, 2019
@ZhiminXiang ZhiminXiang requested a review from mattmoor March 21, 2019 00:23
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2019
knative-prow-robot
knative-prow-robot reviewed Mar 21, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhiminXiang: 2 warnings.

In response to this:

Fixes #
#3051

Proposed Changes

  • Implement the reconciler for Knative Certificate which essentially reconciles Cert-Manager Certificate to request TLS certificates.
  • Add a ConfigMap config-certmanager to configure the Cert-Manager Certificate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/reconciler/v1alpha1/certificate/config/doc.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/testing/listers.go Outdated Show resolved Hide resolved
@ZhiminXiang ZhiminXiang requested review from vagababov and removed request for lichuqiang, jonjohnsonjr and jessiezcc March 21, 2019 00:23
@ZhiminXiang ZhiminXiang removed the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Mar 21, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Mar 21, 2019
@ZhiminXiang ZhiminXiang changed the title [WIP] Reconciler for Knative Certificate Reconciler for Knative Certificate Mar 21, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2019
@ZhiminXiang
Copy link
Author

/test pull-knative-serving-upgrade-tests
/test pull-knative-serving-integration-tests

@ZhiminXiang
Copy link
Author

/test pull-knative-serving-integration-tests

mattmoor
mattmoor reviewed May 1, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Couple comments, but looking good. Can we stage the docs PR on how to install cert-manager before we land this?

hack/generate-yamls.sh Outdated Show resolved Hide resolved
test/e2e-common.sh Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
@mattmoor
Copy link
Member

mattmoor commented May 2, 2019

@ZhiminXiang Once this lands, our release yaml will contain bits expecting cert-manager. Can you stage a docs PR that talks about how to install cert-manager and/or how to apply the cert-manager pieces from the release yaml?

@ZhiminXiang
Copy link
Author

@ZhiminXiang Once this lands, our release yaml will contain bits expecting cert-manager. Can you stage a docs PR that talks about how to install cert-manager and/or how to apply the cert-manager pieces from the release yaml?

The docs PR knative/docs#1281 is ready for review.

@mattmoor
Copy link
Member

mattmoor commented May 7, 2019

image

🎉 This makes me super happy!

cc @csantanapr

@mattmoor
Copy link
Member

mattmoor commented May 8, 2019

/lgtm
/approve

We need the docs PR to go in, but I want this to get some bake time.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@csantanapr
Copy link
Member

@mattmoor you have a hold on this PR, you want to merge it?

@mattmoor
Copy link
Member

mattmoor commented May 8, 2019

/hold cancel

Oops, thanks @csantanapr

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@ZhiminXiang
Copy link
Author

/test pull-knative-serving-upgrade-tests

@mattmoor
Copy link
Member

mattmoor commented May 8, 2019

/retest

1 similar comment
@mattmoor
Copy link
Member

mattmoor commented May 8, 2019

/retest

@mattmoor mattmoor closed this May 8, 2019
@mattmoor mattmoor reopened this May 8, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/networking/v1alpha1/certificate_lifecycle.go 83.3% 77.8% -5.6
pkg/reconciler/certificate/certificate.go Do not exist 79.8%
pkg/reconciler/certificate/config/cert_manager.go Do not exist 100.0%
pkg/reconciler/certificate/config/store.go Do not exist 100.0%
pkg/reconciler/certificate/resources/cert_manager_certificate.go Do not exist 80.0%

@knative-prow-robot knative-prow-robot merged commit cddabb0 into knative:master May 8, 2019
@ZhiminXiang ZhiminXiang mentioned this pull request May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@vagababov vagababov vagababov left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@tcnghia tcnghia

@vagababov vagababov

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ZhiminXiang @mattmoor @knative-prow-robot @csantanapr @knative-metrics-robot @vagababov @tcnghia @googlebot