Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rolling for usual modifiers with target key a custom modifer #907

Open
fleutot opened this issue Oct 17, 2024 · 2 comments
Open

Allow rolling for usual modifiers with target key a custom modifer #907

fleutot opened this issue Oct 17, 2024 · 2 comments

Comments

@fleutot
Copy link

fleutot commented Oct 17, 2024

In my current config,r is a tap-hold-next-release, and e is not.

Pshft Pe Rshft Re gives "E".
Pshft Pr Rshft Rr gives "r".

I understand that I have to make a choice: either I must require my custom tap/hold modifers to be held until after the target key is released, or I need to lose the ability to roll and get both characters.

I can live with learning to not roll, for my custom modifiers.

But what I would like to keep, is the ability to roll when the modifier is control, alt, shift, super, and the target key is a tap-hold-next-release (r above).

Is there a way to let the rolling trigger the modified key for these, or is there a drawback that I don't see now?

This is kind of related to #903

@jokesper
Copy link
Contributor

This is actually a long standing issue. See #524.
I don't know why the PR is marked as Draft or if there are any problems with it (except that it's old and has merge conflicts). This was opened long before I started working on the project (as a contributor, I don't have any access rights).

@fleutot
Copy link
Author

fleutot commented Oct 21, 2024

That sounds good! I'd be happy to build and test this, if someone wants to rebase or merge in master for conflict resolution. I sadly don't have the ha-skills (pun) to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants