Make priority queue only hold string keys

kkowar · Sep 24, 2014 · 56d38d2 · 56d38d2
1 parent ce27ecf
commit 56d38d2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/priority-queue.js b/lib/priority-queue.js
@@ -1,3 +1,5 @@
+var _ = require("lodash");
+
 module.exports = PriorityQueue;
 
 /**
@@ -30,7 +32,7 @@ PriorityQueue.prototype.keys = function() {
  * Returns `true` if **key** is in the queue and `false` if not.
  */
 PriorityQueue.prototype.has = function(key) {
-  return key in this._keyIndices;
+  return _.has(this._keyIndices, key);
 };
 
 /**
@@ -67,7 +69,8 @@ PriorityQueue.prototype.min = function() {
  */
 PriorityQueue.prototype.add = function(key, priority) {
   var keyIndices = this._keyIndices;
-  if (!(key in keyIndices)) {
+  key = String(key);
+  if (!_.has(keyIndices, key)) {
     var arr = this._arr;
     var index = arr.length;
     keyIndices[key] = index;

diff --git a/test/priority-queue-test.js b/test/priority-queue-test.js
@@ -29,7 +29,8 @@ describe("PriorityQueue", function() {
       pq.add(false, 3);
       pq.add(undefined, 4);
       pq.add(null, 5);
-      expect(_.sortBy(pq.keys())).to.eql(_.sortBy(["a", 1, false, undefined, null]));
+      expect(_.sortBy(pq.keys())).to.eql(
+                _.sortBy(["a", "1", "false", "undefined", "null"]));
     });
   });