Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PowerShell #405

Merged
merged 5 commits into from
Mar 5, 2023
Merged

Support PowerShell #405

merged 5 commits into from
Mar 5, 2023

Conversation

bebound
Copy link
Contributor

@bebound bebound commented Mar 5, 2023

Reopen #392 and fix the README.rst

@bebound
Copy link
Contributor Author

bebound commented Mar 5, 2023

There are still some errors, I'll fix them.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.38 ⚠️

Comparison is base (a5b23ce) 80.54% compared to head (91e82fe) 80.16%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #405      +/-   ##
===========================================
- Coverage    80.54%   80.16%   -0.38%     
===========================================
  Files            6        6              
  Lines          740      746       +6     
===========================================
+ Hits           596      598       +2     
- Misses         144      148       +4     
Impacted Files Coverage Δ
argcomplete/shell_integration.py 85.36% <42.85%> (-8.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kislyuk kislyuk merged commit f72506e into kislyuk:develop Mar 5, 2023
@kislyuk
Copy link
Owner

kislyuk commented Mar 5, 2023

Thank you

@kislyuk
Copy link
Owner

kislyuk commented Mar 6, 2023

@bebound can you please update this so that the file register-python-argcomplete.cmd does not get installed on non-Windows platforms by default?

@kislyuk
Copy link
Owner

kislyuk commented Mar 6, 2023

I have deleted the file scripts/register-python-argcomplete.cmd and will not be adding it back. In general, scripts for contributor-supported shells will need to be installed by separate means activated via setuptools extras.

@bebound
Copy link
Contributor Author

bebound commented Mar 7, 2023

Windows user cannot run register-python-argcomplete without this cmd file.

@kislyuk
Copy link
Owner

kislyuk commented Mar 8, 2023

I understand. We need to find a way to only install this file on Windows.

@bebound
Copy link
Contributor Author

bebound commented Mar 13, 2023

How about using entry_points? https://github.com/bebound/argcomplete/tree/entry-point
It works on Linux and Windows. I don't know if it is compatible with tch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants