Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serizba/cppflow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: kirasystems/cppflow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jun 18, 2021

  1. [DEV-14011] Fix memory issue detected by ASan

    The ASan report is as follows:
    
    AddressSanitizer:DEADLYSIGNAL
    =================================================================
    ==74==ERROR: AddressSanitizer: SEGV on unknown address 0x6030bf3b722e (pc 0x7fc277c6ae10 bp 0x7ffe22b2c9a0 sp 0x7ffe22b2c158 T0)
    ==74==The signal is caused by a READ memory access.
        #0 0x7fc277c6ae10  /build/glibc-eX1tMB/glibc-2.31/string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:365
        #1 0x49d947 in __asan_memcpy (/home/docker/kiravision/test/clang-memtest+0x49d947)
        #2 0x50e00a in TF_TString_ResizeUninitialized(TF_TString*, unsigned long) /opt/tensorflow/include/tensorflow/core/platform/ctstring_internal.h:278:7
        #3 0x50ba34 in TF_TString_Copy(TF_TString*, char const*, unsigned long) /opt/tensorflow/include/tensorflow/core/platform/ctstring_internal.h:389:17
        #4 0x50bbac in Model::restore(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/docker/kiravision/cppflow/src/Model.cpp:107:5
        #5 0x4e98e2 in KiraVision::LearnedModel::LearnedModel(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/docker/kiravision/src/LearnedModel.cpp:12:13
        #6 0x4e28ed in KiraVision::TableDetector::TableDetector(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, KiraVision::LogLevel const&) /home/docker/kiravision/src/TableDetector.cpp:13:24
        #7 0x4d058a in main /home/docker/kiravision/test/memtest.cpp:16:31
        #8 0x7fc277bd30b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #9 0x425ccd in _start (/home/docker/kiravision/test/clang-memtest+0x425ccd)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV /build/glibc-eX1tMB/glibc-2.31/string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:365
    ==74==ABORTING
    
    The problem was incorrect initalization of a `TF_TString`. The existing
    code initialized it as `new TF_Tstring` (which is not really any kind of
    initalization, just memory allocation). `TF_TString`'s have to be
    initialized with `TF_TString_Initialize` before they an be used. The
    fact that the offending code is using a `unique_ptr` to ensure deletion
    of the `TF_TString` makes it all a little clunky.
    abertoldi committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    3df6559 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Configuration menu
    Copy the full SHA
    6ff7300 View commit details
    Browse the repository at this point in the history
Loading