This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
Fix dev workflow #223
Merged
Fix dev workflow #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
commented
Nov 26, 2017
pkg/script/kubeadm-config.go
Outdated
| @@ -13,10 +13,12 @@ apiServerExtraArgs: | |||
| controllerManagerExtraArgs: | |||
| kubernetesVersion: {{.KubernetesVersion}} | |||
| schedulerExtraArgs: | |||
| unifiedControlPlaneImage: 10.22.0.1:5000/hyperkube-amd64:{{.HyperkubeTag}} | |||
There was a problem hiding this comment.
TODO: unifiedControlPlaneImage should only be set with --dev
alban
force-pushed
the
alban/fix-dev-workflow
branch
2 times, most recently
from
7243238 to
e4ca2ab
Compare
alban
force-pushed
the
alban/fix-dev-workflow
branch
2 times, most recently
from
5fe34f6 to
ef7982a
Compare
|
Description updated. PR ready for review. |
alban
force-pushed
the
alban/fix-dev-workflow
branch
from
ef7982a to
bfd70e1
Compare
dongsupark
approved these changes
Nov 27, 2017
robertgzr
reviewed
Nov 27, 2017
doc/dev-workflow.md
Outdated
|
|
||
| ### Limitations | ||
|
|
||
| The kyperkube image contains the api server, the controller manager and the scheduler but not `kubeadm`. |
robertgzr
reviewed
Nov 27, 2017
doc/dev-workflow.md
Outdated
|
|
||
| This article describes a step-by-step example of workflow that a Kubernetes developer might follow when patching Kubernetes. | ||
|
|
||
| For the purpose of the article, we will write a new [admission controler](https://kubernetes.io/docs/admin/admission-controllers/) named `DenyAttach` that inconditionally deny all attaching to a container. The end result will be: |
|
really cool 👍 |
Add --hyperkube-tag (or -t) on kube-spawn create to specify which hyperkube Docker image to use. This is useful to compile different versions of Kubernetes and test them in parallel. doc/dev-workflow.md explains in more details how to use it. kube-spawn will start a registry container and push the hyperkube image there under the name 10.22.0.1:5000/hyperkube-amd64:$TAG. Then, kubeadm will pick that image. Use the unifiedControlPlaneImage option in the kubeadm configuration file (>= 1.8) in addition to the old environment variable $KUBE_HYPERKUBE_IMAGE (< 1.8). This means --dev cannot be used anymore on 1.7 branches, but the 1.7 releases still work so it should not be a problem. The dev workflow is now documented in doc/dev-workflow.md Fixes #188
alban
force-pushed
the
alban/fix-dev-workflow
branch
from
bfd70e1 to
a050ccf
Compare
|
Thanks for the reviews. I merged it. To improve further the documentation, we could do the following:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--hyperkube-tag(or-t) onkube-spawn createto specify which hyperkube Docker image to use. This is useful to compile different versions of Kubernetes and test them in parallel.doc/dev-workflow.mdexplains in more details how to use it.kube-spawn will start a
registrycontainer and push the hyperkube image there under the name10.22.0.1:5000/hyperkube-amd64:$TAG. Then, kubeadm will pick that image.Use the
unifiedControlPlaneImageoption in the kubeadm configuration file (>= 1.8) in addition to the old environment variable$KUBE_HYPERKUBE_IMAGE(< 1.8). This means--devcannot be used anymore on 1.7 branches, but the 1.7 releases still work so it should not be a problem.The dev workflow is now documented in doc/dev-workflow.md
Fixes #188
TODO
unifiedControlPlaneImagewith--dev/cc @blixtra