-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Download Rate Limiting #401
Comments
Hey there! Thanks for the report (: Those flags won't do anything since Pinchflat (intentionally) handles the download queue itself. A global rate limit isn't something that's easy to implement, so before I look into that can you provide me with some more info? Are you actively being rate limited or is this just a precaution? Have you tried setting the |
Back from work. A download got stuck with the prove your not a bot message from YT. I did not notice for a while and my vpn ip got banned. No biggy, just cycle to a new one. However, pinchflat seems to just keep hammering regardless of the error ytdlp gives. A max download retries would be handy here. Also maybe display the actual error encounter in the gui someplace? Like a history of commands for each source. As for rate limiting, I have compiled a few playlists that have 500+ items and suspect that downloading in one go will likely burn another ip. I would like to add some element of randomness to the download pattern. So even if its not global but source specific would be nice. As a sidenote, will you add a poToken option? |
Fair point! There is already a list of errors from
Another fair point! This is a really hard thing to architect since each download is (intentionally) independent and I don't know ahead-of-time how long they'll take so I can't preemptively schedule them in a staggered fashion. There are other ways to achieve this that I'll look into (note to self: look into an Elixir Registry or Agent initialized in the main app's supervision tree)
I'll check with the |
So you dont know when they will end, but could you add a random sleep to before each download starts?
Ah sorry, no rush or need to pressure on this one. I understand it is an evolving situation. |
Thank you for the update! I just wanted to let you know that I'll be (mostly) out of cell service for just over a week starting tomorrow. But I'll keep thinking about this and see what I can come up with once I'm back |
I just wanted to touch base with this. Given the challenges YouTube, I had to drop back to using the cookie method mentioned in the thread. I thought it might be useful to have a rate limit. I am using a residential IP but still running into problems Maybe download rate limits would help |
I have an attempted fix for this in #559. I really recommend reading through that but here's the TL;DR:
These changes haven't been released yet since I need to do some testing. If you want to help me test, here's how:
Thank you! |
I pulled down issue-549 and I set it to 5s. Thanks for looking into this. I haven't really put it through significant testing yet however. I am currently passing in my cookies file due to the rampant "you need to log in" thing that google has been tossing around. I just wanted to note that in case that has an impact Is there anything in specific I should keep an eye out for? |
Thank you! I'm mostly looking for two things:
|
For reference. |
How can I set download sleep intervals to avoid rate limits?
yt-dlp has:
Could I set these in yt-dlp-configs/base-config.txt"?
Or would this not work as expected across multiple sources in pinchflat?
Otherwise global sleep requests and interval min-max in Config -> Settings?
Seems better than per Media Profile but your call.
The text was updated successfully, but these errors were encountered: