fix lint issues (oppia#6526)

kevintab95 · Mar 30, 2019 · e7bd68f · e7bd68f
1 parent 7635b37
commit e7bd68f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/core/domain/suggestion_registry.py b/core/domain/suggestion_registry.py
@@ -509,7 +509,8 @@ def accept(self, unused_commit_message):
             raise utils.ValidationError(
                 'The skill with the given id doesn\'t exist.')
         question_services.create_new_question_skill_link(
-            question_dict['id'], self.change.skill_id, constants.DEFAULT_SKILL_DIFFICULTY)
+            question_dict['id'], self.change.skill_id,
+            constants.DEFAULT_SKILL_DIFFICULTY)
 
     def populate_old_value_of_change(self):
         """Populates old value of the change."""

diff --git a/core/templates/dev/head/pages/topics_and_skills_dashboard/SkillsListDirective.js b/core/templates/dev/head/pages/topics_and_skills_dashboard/SkillsListDirective.js
@@ -177,7 +177,7 @@ oppia.directive('skillsList', [
               var supersedingSkillId = result.supersedingSkillId;
               // Transfer questions from the old skill to the new skill.
               TopicsAndSkillsDashboardBackendApiService.mergeSkills(
-                  skill.id, supersedingSkillId).then(function() {
+                skill.id, supersedingSkillId).then(function() {
                 // Broadcast will update the skills list in the dashboard so
                 // that the merged skills are not shown anymore.
                 $rootScope.$broadcast(

diff --git a/core/tests/protractor_utils/TopicsAndSkillsDashboardPage.js b/core/tests/protractor_utils/TopicsAndSkillsDashboardPage.js
@@ -73,15 +73,16 @@ var TopicsAndSkillsDashboardPage = function() {
     waitFor.pageToFullyLoad();
   };
 
-  this.mergeSkillWithIndexToSkillWithIndex = function(oldSkillIndex, newSkillIndex) {
-    mergeSkillsButtons.then(function(elems) {
-      elems[oldSkillIndex].click();
-      skillsListItems.then(function(skills) {
-        skills[newSkillIndex].click();
-        confirmSkillsMergeButton.click();
+  this.mergeSkillWithIndexToSkillWithIndex = (
+    function(oldSkillIndex, newSkillIndex) {
+      mergeSkillsButtons.then(function(elems) {
+        elems[oldSkillIndex].click();
+        skillsListItems.then(function(skills) {
+          skills[newSkillIndex].click();
+          confirmSkillsMergeButton.click();
+        });
       });
     });
-  };
 
   this.navigateToTopicWithIndex = function(index) {
     topicsListItems.then(function(elems) {