Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to the proxy settings #39

Open
vipulg13 opened this issue Sep 2, 2021 · 1 comment
Open

Support to the proxy settings #39

vipulg13 opened this issue Sep 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@vipulg13
Copy link

vipulg13 commented Sep 2, 2021

Dear team,

would you consider extending the support to the proxy-enabled REST client? Since "requests.request()" have already the mechanism to handle proxies, I believe the implementation is straightforward. I have actually extended the client.py and grobid_client.py to handle proxies. I am testing the changes at the moment. If everything works as expected, I would be happy to share the the updated python code.

Regards,
Vipul
@kermitt2 kermitt2 added the enhancement New feature or request label Jul 15, 2022
@lfoppiano
Copy link
Collaborator

@vipulg13 please, feel free to send us a PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lfoppiano @kermitt2 @vipulg13