-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KerasCV and KerasNLP; new structure for KerasHub and KerasTuner #1993
Conversation
Not all KerasCV guides have a KerasHub replacement yet. These guides no longer show up on the site, but I've left them in the repo so they can be ported. |
would https://keras.io/keras_cv/ take to keras_cv page or the keras_hub page? |
@divyashreepathihalli KerasCV page will be gone! keras.io/keras_cv will redirect to keras.io/keras_hub You might want to try rendering locally to get a sense of the new structure. |
I will check it out! |
c58a6d5
to
68fdde7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks great.
The redirects need to be more granular, especially for KerasCV -- anytime there's a relevant page we can point to, we should. Examples:
/api/keras_cv/layers/augmentation/*
- >/api/layers/preprocessing_layers/image_augmentation/
/api/keras_cv/models/backbones/efficientnet_v2/
-> corresponding API page in KerasHub/api/keras_cv/models/tasks/stable_diffusion/
-> corresponding API page in KerasHub (note, this one has quite a few links that point to it!)- etc.
Please go over each one by hand and determine what the best page to redirect to is.
Thanks! Yeah, that is done for KerasTuner/KerasHub/KerasNLP since there's a one-to-one correspondence. But yeah KerasCV will need a more careful touch. Will do! |
68fdde7
to
bb24e30
Compare
@fchollet improved the CV links a bit, though a good bit doesn't have a perfect replacement. E.g. for bounding boxes and preprocessing layers in CV I'm just linking to core Keras preprocessing layers. |
bb24e30
to
a6fbf1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it
guides/keras_hub/xx
->keras_hub/guides/xx
.api/keras_hub/xx
->keras_hub/api/xx
.