Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added erf op to math.py #908

Closed
wants to merge 14 commits into from
Closed

added erf op to math.py #908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6485433
added erf op to math.py
sqali Sep 17, 2023
61c9690
code reformatting done, introduced erf function in jax, torch and numpy
sqali Sep 18, 2023
7960106
shortened comment lines, renamed the new function
sqali Sep 18, 2023
d9f99f2
added decorator above the erf function, added tests under the existin…
sqali Sep 18, 2023
ef05f70
Merge branch 'keras-team:main' into main
sqali Sep 19, 2023
8d4b8eb
changes done to erf functions as per suggestion
sqali Sep 19, 2023
e829832
Merge branch 'keras-team:main' into main
sqali Sep 20, 2023
686f339
Merge branch 'keras-team:main' into main
sqali Sep 21, 2023
6b52b8a
backend.math added to erf function, fenced code block used fo
sqali Sep 21, 2023
7f76459
code reformatting applied
sqali Sep 21, 2023
5efabf5
corrected jax expression, numpy function
sqali Sep 21, 2023
ebe06c3
Merge branch 'keras-team:main' into main
sqali Sep 22, 2023
3f199c3
Update math_test.py
sqali Sep 22, 2023
0307b74
Update math_test.py
sqali Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
corrected jax expression, numpy function
  • Loading branch information
@sqali
sqali committed Sep 21, 2023
commit 5efabf539a4eac8288e563c1a3c00854b8d5c8fb
2 changes: 1 addition & 1 deletion keras_core/backend/jax/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,4 +251,4 @@ def rsqrt(x):


def erf(x):
return jnp.erf(x)
return jax.lax.erf(x)
2 changes: 1 addition & 1 deletion keras_core/backend/numpy/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,4 +305,4 @@ def rsqrt(x):


def erf(x):
return scipy.special.erf(x)
return np.array(scipy.special.erf(x))
6 changes: 3 additions & 3 deletions keras_core/ops/math_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ def test_erf_operation_basic(self):
)

# Output from the erf operation in keras_core
output_from_erf_op = kmath.erf(sample_values).numpy()
output_from_erf_op = kmath.erf(sample_values)

# Assert that the outputs are close
self.assertAllClose(expected_output, output_from_erf_op, atol=1e-5)
Expand All @@ -860,7 +860,7 @@ def test_erf_operation_dtype(self):
expected_output = (2 / np.sqrt(np.pi)) * np.vectorize(math.erf)(
sample_values
)
output_from_erf_op = kmath.erf(sample_values).numpy()
output_from_erf_op = kmath.erf(sample_values)
self.assertAllClose(expected_output, output_from_erf_op, atol=1e-5)

def test_erf_operation_edge_cases(self):
Expand All @@ -869,7 +869,7 @@ def test_erf_operation_edge_cases(self):
expected_edge_output = (2 / np.sqrt(np.pi)) * np.vectorize(math.erf)(
edge_values
)
output_from_edge_erf_op = kmath.erf(edge_values).numpy()
output_from_edge_erf_op = kmath.erf(edge_values)
self.assertAllClose(
expected_edge_output, output_from_edge_erf_op, atol=1e-5
)