Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the import order of pydot and its older forks #20682

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

lkk7
Copy link
Contributor

@lkk7 lkk7 commented Dec 23, 2024

Fixes #20681

Feel free to add your suggestions!

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (3dd958b) to head (fe672c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20682   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files         544      544           
  Lines       50751    50751           
  Branches     7851     7851           
=======================================
  Hits        41604    41604           
  Misses       7252     7252           
  Partials     1895     1895           
Flag Coverage Δ
keras 81.81% <100.00%> (ø)
keras-jax 63.94% <100.00%> (ø)
keras-numpy 58.86% <100.00%> (-0.01%) ⬇️
keras-openvino 29.94% <100.00%> (ø)
keras-tensorflow 64.69% <100.00%> (ø)
keras-torch 63.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pydot maintenance timeline is such a rollercoaster. Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 23, 2024
@fchollet fchollet merged commit c1316e5 into keras-team:master Dec 23, 2024
8 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing the import order of pydot and its forks
4 participants