Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing the import order of pydot and its forks #20681

Closed
lkk7 opened this issue Dec 23, 2024 · 0 comments · Fixed by #20682
Closed

Consider changing the import order of pydot and its forks #20681

lkk7 opened this issue Dec 23, 2024 · 0 comments · Fixed by #20682
Assignees
@sachinprasadhs

Comments

@lkk7
Copy link
Contributor

lkk7 commented Dec 23, 2024 •
edited
Loading

In keras/src/utils/model_visualization.py:

try:
    # pydot-ng is a fork of pydot that is better maintained.
    import pydot_ng as pydot
except ImportError:
    # pydotplus is an improved version of pydot
    try:
        import pydotplus as pydot
    except ImportError:
        # Fall back on pydot if necessary.
        try:
            import pydot
        except ImportError:
            pydot = None

pydotplus has not been updated in 10 years, and pydot-ng has not been updated in 6 years.
Consider using pydot as the first option and the other options as fallbacks instead of the other way around.
pydot has been resurrected some time ago and it's the main project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinprasadhs sachinprasadhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the import order of pydot and its older forks lkk7/keras
2 participants
@lkk7 @sachinprasadhs