fix in implementation of S-DTW backward @taras-sereda #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've found that in your implementation of S-DTW backward, E - matrices are not used, instead you are using G - matrices and their entries are ignoring scaling factors
a, b, c
.What's the reason for this?
My guess you are doing this in order to preserve and propagate gradients, because they are vanishing due to small values of
a, b, c
. But I might be wrong, so I'd be glad to hear your motivation on doing this.Playing with your code, I also found that gradients are vanishing, especially when
bandwitdth=None
.So I'm solving this problem by normalizing distance matrix, by
n_mel_channel
. And with this normalization and exact implementation of S-dtw backward I'm able to converge on overfit experiments quicker then with non-exact computation of s-dtw backward.I'm using these SDT hparams:
here is a small test I'm using for checks:
Curious to hear how your training is going!
Best. Taras