Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-storage-blob.md #68

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

IsharaPannila
Copy link
Contributor

No description provided.

@ahmelsayed
Copy link
Contributor

I'm still hesitant to accept this change. This is not the general contract of blobTrigger in azure functions. blobTrigger behavior is to scan the container logs from storage, store a marker where processing stopped, and interpret new activity to blobs on the container as a "trigger event". That does complicate the implementation of the scaler as it would tie it to azure functions interpretation of how blobTrigger should work, as well as the shared marker resource to let both the runtime and scaler know where the processing was left off.

@jeffhollan
Copy link
Member

Added some comments here to move description to PR kedacore/keda#514

@jeffhollan
Copy link
Member

@IsharaPannila not sure if you ended up making any changes before merged - are these docs still the right ones with limitations or did you change the isActive behavior?

@jeffhollan
Copy link
Member

Oh actually I see you edited it after fact. Thanks!

@jeffhollan jeffhollan merged commit 0b509ca into kedacore:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants