Update RabbitMQ Scaler documentation to include the option of use regex #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex in case of http queue Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
5 tasks
tomkerkhove
approved these changes
Jul 16, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
zroubalik
reviewed
Jul 19, 2021
zroubalik
reviewed
Jul 19, 2021
zroubalik
reviewed
Jul 19, 2021
Co-authored-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
|
I have just applied your suggestions @zroubalik. |
zroubalik
approved these changes
Jul 19, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
zroubalik
approved these changes
Jul 19, 2021
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
zroubalik
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with kedacore/keda#1957
Checklist
Relates to kedacore/keda#743
Relates to kedacore/keda#1957