Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoreNullValues for AWS CloudWatch Scaler #5635

Merged
merged 32 commits into from
Aug 20, 2024
Merged

add ignoreNullValues for AWS CloudWatch Scaler #5635

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
53ea3fd
add errorWhenMetricValueEmpty
robpickerill Mar 28, 2024
4174e93
fix golangci-lint
robpickerill Mar 28, 2024
8e41311
improve error message for empty results
robpickerill Mar 29, 2024
b0d4e84
add error when empty metric values to changelog
robpickerill Mar 29, 2024
7a5f617
rename errorWhenMetricValuesEmpty -> errorWhenNullValues
robpickerill Mar 31, 2024
96a2254
use getParameterFromConfigV2 to read config for errorWhenNullValues
robpickerill Mar 31, 2024
476b4e5
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Mar 31, 2024
0b61f97
add e2e for error state for cw, and improve e2e for min values for cw
robpickerill Apr 3, 2024
c6dc524
remove erroneous print statement
robpickerill Apr 4, 2024
0dc9b77
remove unused vars
robpickerill Apr 4, 2024
1f70736
rename errorWhenMetricValuesEmpty -> ignoreNullValues
robpickerill Apr 11, 2024
185db21
move towards shared package for e2e aws
robpickerill Apr 13, 2024
9f5bbf5
minMetricValue optionality based on ignoreNullValues
robpickerill Apr 14, 2024
97f47a0
fail fast
robpickerill Apr 26, 2024
9d0ce60
Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_…
robpickerill Apr 26, 2024
a8959f2
Apply suggestions from code review
robpickerill Apr 26, 2024
702817f
fail fast
robpickerill Apr 26, 2024
2862e9c
fix broken new line
robpickerill Apr 26, 2024
f390bc4
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Apr 26, 2024
c684676
fix broken new lines
robpickerill Apr 26, 2024
5aceb72
assert no scaling changes in e2e, and set false for required in minMe…
robpickerill May 4, 2024
96b4097
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill May 20, 2024
9374c26
fix ci checks
robpickerill May 21, 2024
1898924
Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwat…
robpickerill May 21, 2024
a97992b
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill May 28, 2024
943f929
Merge branch 'kedacore:main' into cloudwatch-error-when-empty-metrics
robpickerill May 31, 2024
ddd9f63
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Jun 8, 2024
2e76a9b
fix merge conflicts
robpickerill Jun 8, 2024
43a2c3f
fix e2e package names
robpickerill Jun 10, 2024
a241593
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Aug 16, 2024
8e436c3
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Aug 20, 2024
d55be16
Merge branch 'main' into cloudwatch-error-when-empty-metrics
robpickerill Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into cloudwatch-error-when-empty-metrics
  • Loading branch information
@robpickerill
robpickerill authored Aug 20, 2024
commit 8e436c30e28e1b04194ef843c71b88fdae8a3035

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.