Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation on hpa to disable ownership validation #5536

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Add annotation on hpa to disable ownership validation #5536

merged 5 commits into from
Apr 15, 2024

Conversation

junekhan
Copy link
Contributor

@junekhan junekhan commented Feb 27, 2024 •
edited
Loading

Add annotation validations.keda.sh/shared-ownership on hpa to disable ownership validation

Checklist

Fixes #5516

Relates to #

@junekhan junekhan requested a review from a team as a code owner February 27, 2024 09:10
@junekhan junekhan changed the title feat: add annotation on hpa to disable ownership validation Add annotation on hpa to disable ownership validation Feb 27, 2024
@junekhan
feat: add annotation validations.keda.sh/shared-ownership on hpa to…
64c5248 
… disable validation

Signed-off-by: June Han <sorrowitsch@gmail.com>
@junekhan junekhan force-pushed the feat/disable-ownership-validation branch from f69cd5a to 64c5248 Compare February 27, 2024 09:30
zroubalik
zroubalik reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably name this annotation validations.keda.sh/hpa-ownership or something around that, to make it more clear what is it about.

WDYT @kedacore/keda-core-contributors

@tomkerkhove
Copy link
Member

Agreed!

@junekhan
chore: rename the annotation to validations.keda.sh/hpa-ownership a…
c01c86c 
…s suggested

Signed-off-by: June Han <sorrowitsch@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

zroubalik
zroubalik reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junekhan could you please fix the conflict in the changelog and also document this new annotation? https://keda.sh/docs/2.13/concepts/scaling-deployments/

junekhan added 3 commits April 11, 2024 10:31
@junekhan
Merge branch 'main' into feat/disable-ownership-validation
a6d5c60 
Signed-off-by: June Han <sorrowitsch@gmail.com>
@junekhan
chore: reorder changelog
b7e87bf 
Signed-off-by: June Han <sorrowitsch@gmail.com>
@junekhan
chore: reorder changelog
29b4060 
Signed-off-by: June Han <sorrowitsch@gmail.com>
@junekhan junekhan mentioned this pull request Apr 11, 2024
Merged
1 task
@junekhan
Copy link
Contributor Author

@junekhan could you please fix the conflict in the changelog and also document this new annotation? https://keda.sh/docs/2.13/concepts/scaling-deployments/

I've fixed the conflict and updated the document for v2.13.

@zroubalik zroubalik merged commit bcaf5c0 into kedacore:main Apr 15, 2024
19 of 20 checks passed
@junekhan junekhan deleted the feat/disable-ownership-validation branch June 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting disabling admission rules based on resource annotation
4 participants
@junekhan @tomkerkhove @zroubalik @JorTurFer