Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #5989: fix rebalancer auto deleted failed #5994

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Automated cherry pick of #5989: fix rebalancer auto deleted failed #5994

merged 1 commit into from
Dec 30, 2024

Conversation

deefreak
Copy link

@deefreak deefreak commented Dec 30, 2024 •
edited by RainbowMango
Loading

Cherry pick of #5989 on release-1.11.
#5989: fix rebalancer auto deleted failed
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the bug of WorkloadRebalancer doesn't get deleted after TTL.

@chaosi-zju @deefreak
fix rebalancer auto deleted failed
26b5735 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2024
@deefreak deefreak mentioned this pull request Dec 30, 2024
Closed
3 tasks
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.51%. Comparing base (0d4da5d) to head (26b5735).

Files with missing lines Patch % Lines
...orkloadrebalancer/workloadrebalancer_controller.go 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.11    #5994      +/-   ##
================================================
- Coverage         31.51%   31.51%   -0.01%     
================================================
  Files               645      645              
  Lines             54327    54325       -2     
================================================
- Hits              17119    17118       -1     
+ Misses            36138    36137       -1     
  Partials           1070     1070
Flag Coverage Δ
unittests 31.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RainbowMango
RainbowMango approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@karmada-bot karmada-bot merged commit c087cfe into karmada-io:release-1.11 Dec 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deefreak @codecov-commenter @karmada-bot @RainbowMango @chaosi-zju