Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize the naming of karmada secrets in karmadactl method #5524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

standardize the naming of karmada secrets in karmadactl method #5524

wants to merge 1 commit into from

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 11, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.

However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.

This PR aims to standardize the naming of karmada secrets in karmadactl installation method.

Which issue(s) this PR fixes:

Fixes part of #5363

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmadactl: standardize the naming of karmada secrets in karmadactl installation method

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2024
@chaosi-zju chaosi-zju mentioned this pull request Sep 11, 2024
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.79487% with 22 lines in your changes missing coverage. Please review.

Project coverage is 34.19%. Comparing base (ef7d528) to head (01eb85b).

Files with missing lines Patch % Lines
pkg/karmadactl/cmdinit/kubernetes/deploy.go 16.66% 19 Missing and 1 partial ⚠️
pkg/karmadactl/cmdinit/cert/cert.go 0.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5524      +/-   ##
==========================================
+ Coverage   34.15%   34.19%   +0.03%     
==========================================
  Files         643      643              
  Lines       44503    44525      +22     
==========================================
+ Hits        15201    15225      +24     
+ Misses      28145    28144       -1     
+ Partials     1157     1156       -1
Flag Coverage Δ
unittests 34.19% <71.79%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju force-pushed the secret-karmadactl branch 2 times, most recently from 1e349db to 1232e65 Compare September 12, 2024 02:49
@chaosi-zju
standardize the naming of karmada secrets in karmadactl method
01eb85b 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@chaosi-zju chaosi-zju mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

@wuyingjun-lucky wuyingjun-lucky Awaiting requested review from wuyingjun-lucky

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaosi-zju @karmada-bot @codecov-commenter