Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented config loading via require #504

Closed
wants to merge 5 commits into from
Closed

Implemented config loading via require #504

wants to merge 5 commits into from

Conversation

pavelgj
Copy link
Contributor

@pavelgj pavelgj commented Apr 17, 2013

@pavelgj
Copy link
Contributor Author

pavelgj commented Apr 17, 2013

Not really sure why travis build is failing. The tests it's complaining about run fine locally.

@pavelgj
Copy link
Contributor Author

pavelgj commented Apr 17, 2013

@vojtajina Pushed a fix for coffee config files.

@vojtajina
Copy link
Contributor

Awesome, if you rebase on the latest master, travis should be fine....

@vojtajina
Copy link
Contributor

The travis is failing, because path.resolve() has to be non empty string since 0.10 node.

@vojtajina
Copy link
Contributor

Just change the line 71 to config.basePath = path.resolve(config.basePath || '.');

@pavelgj
Copy link
Contributor Author

pavelgj commented Apr 17, 2013

Yey, it's green!

@vojtajina
Copy link
Contributor

Squashed and merged as c32e0cc

@vojtajina vojtajina closed this Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelgj @vojtajina