Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): poll every 10s to avoid rate limit. #3388

Merged
merged 1 commit into from
Oct 21, 2019
Merged

fix(ci): poll every 10s to avoid rate limit. #3388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@
"husky": "^0.14.3",
"jasmine-core": "^3.4.0",
"karma-browserify": "^6.0.0",
"karma-browserstack-launcher": "^1.4.0",
"karma-browserstack-launcher": "^1.5.0",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^2.2.0",
"karma-firefox-launcher": "*",
Expand Down
22 changes: 5 additions & 17 deletions test/client/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,6 @@ var launchers = {
os: 'Windows',
os_version: '7'
}
// TODO: Figure out why these fail on browserstack
// ,
// bs_ie_8: {
// base: 'BrowserStack',
// browser: 'ie',
// browser_version: '8.0',
// os: 'Windows',
// os_version: '7'
// },
// bs_ie_7: {
// base: 'BrowserStack',
// browser: 'ie',
// browser_version: '7.0',
// os: 'Windows',
// os_version: 'XP'
// }
}

var browsers = []
Expand Down Expand Up @@ -157,7 +141,11 @@ module.exports = function (config) {
forceJSONP: true,

browserStack: {
project: 'Karma'
project: 'Karma',
// The karma-browserstack-launcher polls for each browser.
// With many browsers the 120 requests per minute limit is hit
// resulting in fails Error: 403 Forbidden (Rate Limit Exceeded)
pollingTimeout: 10000
}
})
}