Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watcher): Allow using braces in watcher #1251

Closed
wants to merge 1 commit into from
Closed

feat(watcher): Allow using braces in watcher #1251

wants to merge 1 commit into from

Conversation

JetFault
Copy link
Contributor

Expands braces in watcher, so you can watch: ['a/{b,c}'] which would
expand to ['a/b', 'a/c']

Closes #1249

@JetFault
feat(watcher): Allow using braces in watcher
ecf7b94 
Expands braces in watcher, so you can watch: ['a/{b,c}'] which would
expand to ['a/b', 'a/c']

Closes karma-runner#1249
@JetFault JetFault force-pushed the feature-watcher-braces branch from 5affa28 to ecf7b94 Compare November 24, 2014 20:07
@maksimr
Copy link
Contributor

maksimr commented Nov 24, 2014

@JetFault good job 👍

@maksimr
Copy link
Contributor

maksimr commented Nov 24, 2014

#merge

@karmarunnerbot
Copy link
Member

Sent to presubmit as presubmit-canary-pr-1251 Presubmit branch - Travis status

@JetFault JetFault mentioned this pull request Nov 25, 2014
Closed
@maksimr
Copy link
Contributor

maksimr commented Nov 25, 2014

Merged to canary branch

@JetFault
Copy link
Contributor Author

@maksimr Thanks!

@vojtajina vojtajina closed this Dec 31, 2014
@dmitriz
Copy link

dmitriz commented Apr 15, 2015

Still does not work with globs such as:

  'src/{bindHtml,position}/**/*.js',

DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/{bindHtml,position}"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/bindHtml"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/position"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/typeahead"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/bindHtml"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/position"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/typeahead"

@dmitriz dmitriz mentioned this pull request Apr 15, 2015
Closed
@maksimr
Copy link
Contributor

maksimr commented Apr 15, 2015

@dmitriz
What version of karma you use?

@dmitriz
Copy link

dmitriz commented Apr 15, 2015

Sorry, should have mentioned:

$> karma --version; node -v; npm -v
Karma version: 0.12.31
v0.12.2
2.7.4

@maksimr
Copy link
Contributor

maksimr commented Apr 15, 2015

@dmitriz Thanks!

That feat was merged to canary branch. You can install canary version of karma and all should work

npm install karma@canary

@dmitriz
Copy link

dmitriz commented Apr 15, 2015

Thanks - that works brilliantly!

How about mention it here - can help others:
http://karma-runner.github.io/0.12/intro/installation.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autowatch with wildcards doesn't work
5 participants
@JetFault @maksimr @karmarunnerbot @dmitriz @vojtajina