Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: support HTTPMethodsEncodingParametersInURI #453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FIX: support HTTPMethodsEncodingParametersInURI #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7299a13
FIX: support `HTTPMethodsEncodingParametersInURI`
kisekied Jun 6, 2018
44be457
Update YTKBaseRequest.m
kisekied Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions YTKNetwork/YTKBaseRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,9 @@ typedef void(^YTKRequestCompletionBlock)(__kindof YTKBaseRequest *request);
/// Additional HTTP request header field.
- (nullable NSDictionary<NSString *, NSString *> *)requestHeaderFieldValueDictionary;

/// HTTP methods for which serialized requests will encode parameters as a query string. `GET`, `HEAD`, and `DELETE` by default.
- (nullable NSSet<NSString *> *)HTTPMethodsEncodingParametersInURI;

/// Use this to build custom request. If this method return non-nil value, `requestUrl`, `requestTimeoutInterval`,
/// `requestArgument`, `allowsCellularAccess`, `requestMethod` and `requestSerializerType` will all be ignored.
- (nullable NSURLRequest *)buildCustomUrlRequest;
Expand Down
4 changes: 4 additions & 0 deletions YTKNetwork/YTKBaseRequest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ - (NSDictionary *)requestHeaderFieldValueDictionary {
return nil;
}

- (NSSet *)HTTPMethodsEncodingParametersInURI {
return [NSSet setWithObjects:@"GET", @"HEAD", @"DELETE", nil];
}

- (NSURLRequest *)buildCustomUrlRequest {
return nil;
}
Expand Down
2 changes: 2 additions & 0 deletions YTKNetwork/YTKNetworkAgent.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ - (AFHTTPRequestSerializer *)requestSerializerForRequest:(YTKBaseRequest *)reque

requestSerializer.timeoutInterval = [request requestTimeoutInterval];
requestSerializer.allowsCellularAccess = [request allowsCellularAccess];
requestSerializer.HTTPMethodsEncodingParametersInURI = [request HTTPMethodsEncodingParametersInURI];


// If api needs server username and password
NSArray<NSString *> *authorizationHeaderFieldArray = [request requestAuthorizationHeaderFieldArray];
Expand Down