Made build flags consistent in Node gcov build

kallisti5 · Oct 13, 2015 · a89d9e7 · a89d9e7
1 parent c52dfac
commit a89d9e7
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 32 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -54,6 +54,24 @@
     'include_dirs': [
       '.',
       'include'
+    ],
+    'conditions': [
+      ['OS != "win"', {
+        'conditions': [
+          ['config=="gcov"', {
+            'cflags': [
+              '-ftest-coverage',
+              '-fprofile-arcs',
+              '-O0'
+            ],
+            'ldflags': [
+              '-ftest-coverage',
+              '-fprofile-arcs'
+            ]
+          }
+         ]
+        ]
+      }],
     ]
   },
   'targets': [
@@ -278,22 +296,6 @@
         '-g'
       ],
       "conditions": [
-        ['OS != "win"', {
-          'conditions': [
-            ['config=="gcov"', {
-              'cflags': [
-                '-ftest-coverage',
-                '-fprofile-arcs',
-                '-O0'
-              ],
-              'ldflags': [
-                '-ftest-coverage',
-                '-fprofile-arcs'
-              ]
-            }
-           ]
-          ]
-        }],
         ['OS == "mac"', {
           'xcode_settings': {
             'MACOSX_DEPLOYMENT_TARGET': '10.9',

diff --git a/templates/binding.gyp.template b/templates/binding.gyp.template
@@ -56,6 +56,24 @@
       'include_dirs': [
         '.',
         'include'
+      ],
+      'conditions': [
+        ['OS != "win"', {
+          'conditions': [
+            ['config=="gcov"', {
+              'cflags': [
+                '-ftest-coverage',
+                '-fprofile-arcs',
+                '-O0'
+              ],
+              'ldflags': [
+                '-ftest-coverage',
+                '-fprofile-arcs'
+              ]
+            }
+           ]
+          ]
+        }],
       ]
     },
     'targets': [
@@ -95,22 +113,6 @@
           '-g'
         ],
         "conditions": [
-          ['OS != "win"', {
-            'conditions': [
-              ['config=="gcov"', {
-                'cflags': [
-                  '-ftest-coverage',
-                  '-fprofile-arcs',
-                  '-O0'
-                ],
-                'ldflags': [
-                  '-ftest-coverage',
-                  '-fprofile-arcs'
-                ]
-              }
-             ]
-            ]
-          }],
           ['OS == "mac"', {
             'xcode_settings': {
               'MACOSX_DEPLOYMENT_TARGET': '10.9',