Skip to content

Commit

Permalink
Merge bitcoin#16236: fuzz: Log output even if fuzzer failed
Browse files Browse the repository at this point in the history
fa410f6 test: Suppress false positive leak in secure_allocator<RNGState> (MarcoFalke)
fa35c42 test: Log output even if fuzzer failed (MarcoFalke)

Pull request description:

  Also suppress a false positive detected leak

ACKs for commit fa410f:
  practicalswift:
    utACK fa410f6

Tree-SHA512: 224a72ae0dd9bbe7debda17cd626c01cfbd0e45d7df47a2b591ce8ea386951ad94f4c0677dd268079a4caac382c5acac03199146015a95c308a633e9e4f84c09
  • Loading branch information
MarcoFalke committed Jun 18, 2019
2 parents 0b68fca + fa410f6 commit ac4d38c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/fuzz/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,10 @@ def run_once(*, corpus, test_list, build_dir, export_coverage):
os.path.join(corpus, t),
]
logging.debug('Run {} with args {}'.format(t, args))
output = subprocess.run(args, check=True, stderr=subprocess.PIPE, universal_newlines=True).stderr
result = subprocess.run(args, stderr=subprocess.PIPE, universal_newlines=True)
output = result.stderr
logging.debug('Output: {}'.format(output))
result.check_returncode()
if not export_coverage:
continue
for l in output.splitlines():
Expand Down
3 changes: 3 additions & 0 deletions test/sanitizer_suppressions/lsan
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ leak:libqminimal
leak:libQt5Core
leak:libQt5Gui
leak:libQt5Widgets

# false-positive due to use of secure_allocator<>
leak:GetRNGState

0 comments on commit ac4d38c

Please sign in to comment.