Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch mode #164

Closed
kaleidawave opened this issue Jun 13, 2024 · 1 comment · Fixed by #202
Closed

Watch mode #164

kaleidawave opened this issue Jun 13, 2024 · 1 comment · Fixed by #202
Labels
enhancement New feature or request just-rust No TypeScript / type checking knowledge needed

Comments

@kaleidawave
Copy link
Owner

It would be great to have a --watch mode for the ezno check command. Effectively running ezno check anytime a file in the project is updated.

notify: https://docs.rs/notify/latest/notify looks like a good library to do this!

Currently the checker doesn't do anything incremental. So it is fine just to call check_project again and again without any fine grained specifics for only part of a project to be checked / invalidated.

One consideration is whether then watch will support glob syntax (that is coming in #155)? Maybe the watched file could be run through Pattern::matches

@kaleidawave kaleidawave added enhancement New feature or request good-first-issue PRs welcome 🙏 just-rust No TypeScript / type checking knowledge needed labels Jun 13, 2024
@kaleidawave kaleidawave pinned this issue Jun 20, 2024
@Tommypop2 Tommypop2 mentioned this issue Aug 30, 2024
Merged
@kaleidawave kaleidawave unpinned this issue Sep 29, 2024
@kaleidawave kaleidawave removed the good-first-issue PRs welcome 🙏 label Sep 29, 2024
@kaleidawave
Copy link
Owner Author

This will be fixed in #202. Haven't that PR merged yet as I need to find the time to review it and have a deeper think about incremental checking. Will be in the next release though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request just-rust No TypeScript / type checking knowledge needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add watch mode support Tommypop2/ezno
1 participant
@kaleidawave