Skip to content

Commit

Permalink
replace the return type of methods which emit only once from observab…
Browse files Browse the repository at this point in the history 
…le to single
  • Loading branch information
Geonu committed Aug 25, 2019
1 parent f07ec61 commit 516bf34
Showing 2 changed files with 107 additions and 108 deletions.
30 changes: 14 additions & 16 deletions Sources/Database/FIRDatabaseQuery+Rx.swift
View file
Original file line number Diff line number Diff line change
@@ -79,16 +79,15 @@ extension Reactive where Base: DatabaseQuery {
* @param block The block that should be called. It is passed the data as a FIRDataSnapshot.
* @param cancelBlock The block that will be called if you don't have permission to access this data
*/
public func observeSingleEvent(_ eventType: DataEventType) -> Observable<DataSnapshot> {
return Observable.create { observer in
self.base.observeSingleEvent(of: eventType, with: { snapshot in
observer.onNext(snapshot)
observer.onCompleted()
}, withCancel: { error in
observer.onError(error)
public func observeSingleEvent(_ eventType: DataEventType) -> Single<DataSnapshot> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.observeSingleEvent(of: eventType, with: { (snapshot) in
singleEventListener(.success(snapshot))
}, withCancel: { (error) in
singleEventListener(.error(error))
})
return Disposables.create()
}
})
}

/**
@@ -101,15 +100,14 @@ extension Reactive where Base: DatabaseQuery {
* @param block The block that should be called. It is passed the data as a FIRDataSnapshot and the previous child's key.
* @param cancelBlock The block that will be called if you don't have permission to access this data
*/
public func observeSingleEventAndPreviousSiblingKey(_ eventType: DataEventType) -> Observable<PreviousSiblingKeyDataSnapshot> {
return Observable.create { observer in
self.base.observeSingleEvent(of: eventType, andPreviousSiblingKeyWith: { snapshot, prevKey in
observer.onNext(PreviousSiblingKeyDataSnapshot(snapshot, prevKey))
observer.onCompleted()
}, withCancel: { error in
observer.onError(error)
public func observeSingleEventAndPreviousSiblingKey(_ eventType: DataEventType) -> Single<PreviousSiblingKeyDataSnapshot> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.observeSingleEvent(of: eventType, andPreviousSiblingKeyWith: { (snapshot, prevKey) in
singleEventListener(.success(PreviousSiblingKeyDataSnapshot(snapshot, prevKey)))
}, withCancel: { (error) in
singleEventListener(.error(error))
})
return Disposables.create()
}
})
}
}
185 changes: 93 additions & 92 deletions Sources/Database/FIRDatabaseReference+Rx.swift
View file
Original file line number Diff line number Diff line change
@@ -20,18 +20,18 @@ extension Reactive where Base: DatabaseReference {
* @param value The value to be written.
* @param priority The priority to be attached to that data.
*/
public func setValue(_ value: Any?, andPriority priority: Any? = nil) -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.setValue(value, andPriority: priority, withCompletionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func setValue(_ value: Any?, andPriority priority: Any? = nil) -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.setValue(value, andPriority: priority, withCompletionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -43,18 +43,18 @@ extension Reactive where Base: DatabaseReference {
*
* remove: is equivalent to calling setValue:nil
*/
public func removeValue() -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.removeValue(completionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func removeValue() -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.removeValue(completionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -80,18 +80,18 @@ extension Reactive where Base: DatabaseReference {
*
* @param priority The priority to set at the specified location.
*/
public func setPriority(_ priority: Any?) -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.setPriority(priority, withCompletionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func setPriority(_ priority: Any?) -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.setPriority(priority, withCompletionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -100,18 +100,18 @@ extension Reactive where Base: DatabaseReference {
*
* @param values A dictionary of the keys to change and their new values
*/
public func updateChildValues(_ values: [AnyHashable: Any]) -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.updateChildValues(values, withCompletionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func updateChildValues(_ values: [AnyHashable: Any]) -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.updateChildValues(values, withCompletionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -122,18 +122,18 @@ extension Reactive where Base: DatabaseReference {
* @param value The value to be set after the connection is lost.
* @param priority The priority to be set after the connection is lost.
*/
public func onDisconnectSetValue(_ value: Any?, andPriority priority: Any? = nil) -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.onDisconnectSetValue(value, andPriority: priority, withCompletionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func onDisconnectSetValue(_ value: Any?, andPriority priority: Any? = nil) -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.onDisconnectSetValue(value, andPriority: priority, withCompletionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -143,18 +143,18 @@ extension Reactive where Base: DatabaseReference {
*
* onDisconnectRemoveValue is especially useful for implementing "presence" systems.
*/
public func onDisconnectRemoveValue() -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.onDisconnectRemoveValue(completionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func onDisconnectRemoveValue() -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.onDisconnectRemoveValue(completionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -165,37 +165,37 @@ extension Reactive where Base: DatabaseReference {
*
* @param values A dictionary of child node keys and the values to set them to after the connection is lost.
*/
public func onDisconnectUpdateChildValues(_ values: [AnyHashable: Any]) -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.onDisconnectUpdateChildValues(values, withCompletionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func onDisconnectUpdateChildValues(_ values: [AnyHashable: Any]) -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.onDisconnectUpdateChildValues(values, withCompletionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
* Cancel any operations that are set to run on disconnect. If you previously called onDisconnectSetValue:,
* onDisconnectRemoveValue:, or onDisconnectUpdateChildValues:, and no longer want the values updated when the
* connection is lost, call cancelDisconnectOperations:
*/
public func cancelDisconnectOperations() -> Observable<DatabaseReference> {
return Observable.create { observer in
self.base.cancelDisconnectOperations(completionBlock: { error, ref in
guard let error = error else {
observer.onNext(ref)
observer.onCompleted()
return
}
observer.onError(error)
public func cancelDisconnectOperations() -> Single<DatabaseReference> {
return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.cancelDisconnectOperations(completionBlock: { (error, ref) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(ref))
}
})
return Disposables.create()
}
})
}

/**
@@ -214,18 +214,19 @@ extension Reactive where Base: DatabaseReference {
* @param completionBlock This block will be triggered once the transaction is complete, whether it was successful or not. It will indicate if there was an error, whether or not the data was committed, and what the current value of the data at this location is.
* @param localEvents Set this to NO to suppress events raised for intermediate states, and only get events based on the final state of the transaction.
*/
public func runTransactionBlock(_ block: @escaping (MutableData) -> TransactionResult, withLocalEvents: Bool) -> Observable<DatabaseReferenceTransactionResult> {
return Observable.create { observer in
self.base.runTransactionBlock(block, andCompletionBlock: { error, committed, snapshot in
guard let error = error else {
observer.onNext(DatabaseReferenceTransactionResult(committed, snapshot))
observer.onCompleted()
return
}
observer.onError(error)
}, withLocalEvents: withLocalEvents)
public func runTransactionBlock(_ block: @escaping (MutableData) -> TransactionResult, withLocalEvents: Bool) -> Single<DatabaseReferenceTransactionResult> {

return Single.create(subscribe: { (singleEventListener) -> Disposable in
self.base.runTransactionBlock(block, andCompletionBlock: { (error, committed, snapshot) in
if let error = error {
singleEventListener(.error(error))
}
else {
singleEventListener(.success(DatabaseReferenceTransactionResult(committed, snapshot)))
}
})
return Disposables.create()
}
})
}

/**
@@ -243,7 +244,7 @@ extension Reactive where Base: DatabaseReference {
* @param block This block receives the current data at this location and must return an instance of FIRTransactionResult
* @param completionBlock This block will be triggered once the transaction is complete, whether it was successful or not. It will indicate if there was an error, whether or not the data was committed, and what the current value of the data at this location is.
*/
public func runTransactionBlock(_ block: @escaping (MutableData) -> TransactionResult) -> Observable<DatabaseReferenceTransactionResult> {
public func runTransactionBlock(_ block: @escaping (MutableData) -> TransactionResult) -> Single<DatabaseReferenceTransactionResult> {
return self.runTransactionBlock(block, withLocalEvents: true)
}
}

0 comments on commit 516bf34

Please sign in to comment.