Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test that spv works across the Pact4->Pact5 transition #2099

Merged
merged 1 commit into from
Jan 14, 2025
Merged

add a test that spv works across the Pact4->Pact5 transition #2099

merged 1 commit into from
Jan 14, 2025

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Jan 13, 2025

Change-Id: If184ef67386c53a77b4aee1fe3c74198efa78452

@chessai chessai force-pushed the chessai/spv-pact4-pact5-transition-test branch from df2e2a1 to e5e5fe4 Compare January 13, 2025 20:18
edmundnoble
edmundnoble reviewed Jan 13, 2025
View reviewed changes
src/Chainweb/Pact/Types.hs Outdated Show resolved Hide resolved
test/lib/Chainweb/Test/TestVersions.hs Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Outdated Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Outdated Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Outdated Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs
checkIsVersion Pact5

let sendHeight = sendCut ^?! ixg srcChain . blockHeight
spvProof <- createTransactionOutputProof_ (fx ^. to _cutFixture . CutFixture.fixtureWebBlockHeaderDb) (fx ^. to _cutFixture . CutFixture.fixturePayloadDb) targetChain srcChain sendHeight 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized we aren't using the /spv endpoint here or in the original SPV test, maybe we should start doing that in a subsequent PR just for more realism.

test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Outdated Show resolved Hide resolved
test/unit/Chainweb/Test/Pact5/RemotePactTest.hs Show resolved Hide resolved
@chessai chessai force-pushed the chessai/spv-pact4-pact5-transition-test branch from e5e5fe4 to 5f6a568 Compare January 13, 2025 20:45
edmundnoble
edmundnoble previously approved these changes Jan 13, 2025
View reviewed changes
@edmundnoble edmundnoble enabled auto-merge January 13, 2025 20:47
@edmundnoble edmundnoble added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 13, 2025
@chessai
add a test that spv works across the Pact4->Pact5 transition
8e5ff9a 
Change-Id: If184ef67386c53a77b4aee1fe3c74198efa78452
@chessai chessai force-pushed the chessai/spv-pact4-pact5-transition-test branch from 5f6a568 to 8e5ff9a Compare January 14, 2025 16:38
@edmundnoble edmundnoble enabled auto-merge January 14, 2025 16:40
@edmundnoble edmundnoble added this pull request to the merge queue Jan 14, 2025
Merged via the queue into master with commit 65991a0 Jan 14, 2025
40 of 41 checks passed
@edmundnoble edmundnoble deleted the chessai/spv-pact4-pact5-transition-test branch January 14, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundnoble edmundnoble edmundnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chessai @edmundnoble