Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions are in {{}} instead of {{{}}} #72

Open
Zylofan opened this issue Feb 22, 2023 · 6 comments
Open

Descriptions are in {{}} instead of {{{}}} #72

Zylofan opened this issue Feb 22, 2023 · 6 comments

Comments

@Zylofan
Copy link

Zylofan commented Feb 22, 2023

Most if not all the descriptions from the playbooks to the items are in double { instead of triple. This is a problem as most texts in foundry are forced into

tags. Without the third {. the tags are treated as text and so new content not from the system like additional playbooks will have the tags show up in their descriptions.

This doesn't effect the system descriptions because foundry stores them differently. Though they can suffer the same fate if the compendium is unlocked and they are opened.

@justinross
Copy link
Owner

Thanks for the report.

Are there specific descriptions you're seeing issue with?

Mostly, I don't want text data output as HTML, because frankly I don't trust users to not (intentionally or otherwise) put weird stuff in that will mess up layouts. :)

That is to say, if there are places you're seeing issues, I can make sure html tags are getting stripped out before it's rendered (pretty sure I'm already doing so in one or two places), but I'm probably not going to change much (if anything) over to outputting HTML.

@Zylofan
Copy link
Author

Zylofan commented Feb 22, 2023 via email

@justinross
Copy link
Owner

Any interest in testing a fix? You'll need to uninstall (I think) the module and reinstall it with this manifest url: https://github.com/justinross/foundry-bitd-alternate-sheets/releases/download/1.04b/module.json

No major changes or changes to data structure, so it should be pretty safe, but I'd still back up your world, just in case.

@Zylofan
Copy link
Author

Zylofan commented Feb 22, 2023 via email

@justinross
Copy link
Owner

justinross commented Feb 22, 2023 via email

@EffEssEmm
Copy link

Hey Justin, has this fix been implemented yet? Came across (what I assume to be) the same problem when I was messing with experience clues for a blades hack. When referenced on the sheet, they were displaying paragraph tags, as the editor seems to force them on all inputs. Ended up getting around this by adding the triple brackets indicated above. {{selected_playbook.system.experience_clues}} -> {{{selected_playbook.system.experience_clues}}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants