Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer experience #48

Merged
merged 33 commits into from
Apr 17, 2021
Merged

Update developer experience #48

merged 33 commits into from
Apr 17, 2021

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Apr 16, 2021

Hooray jupyterlite! I'm excited to start digging into #41 (and in turn getting others excited), but there's a fair amount of "read the source" right now, which is fine! While digging into it, I found a fair number of things that could be quickly updated to improve the developer "curb appeal", and pave the way for more contribution.

Of course, if any of these things aren't fun, we can take them out, split them up, whatever!

  • package.json
    • rework yarn tasks
      • watch
      • split build into build:lib and build:app
      • make prettier quieter
      • increase the printWidth to 88
      • prettier more: markdowns, yamls, etc.
      • add serve (appears broken for me) and serve:py (used in proxy)
  • yarnrc
    • add .yarn-packages for local mirroring
    • set some defaults (timeouts, etc.)
  • adds metapackage
  • docs
    • flesh out CONTRIBUTING
    • README
      • remove dev stuff
      • add badges
        • binder
        • ci
  • adds a binder this pr
    • conda env with lab, classic, etc.
    • jupyter-server-proxy, with a (strawman) lightbulb logo
      • always tries to redirect to doc/workspaces/auto-X?reset
        • disabled apputils-extension:resolver, seems to do the thing, not sure what side-effects this may have, but workspaces deserve special consideration, anyway...
      • pyodide kernels die
        • i'm giving up here, as this happens locally, too... but only
          • if the browser console isn't open, in classic heisenberg fashion
          • in chromium (FF LTS is fine, so Works For Me!)
  • app
    • replace all static bundle references and pageInfo with dynamic ones that sniff the window.location
      • the kernels all seem to fail, and thrash against the (non-existent) endpoint
        • calculate the websocket url from the baseUrl
      • favicons, too
  • .github
    • add issue/pr templates (just copied the core ones, mostly)
    • add node_modules and .yarn-packages caching to workflow

@vercel
Copy link

vercel bot commented Apr 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jtpx/jupyterlite/J8x8Zj7dEiStaJnrhFoSamdk9TTw
✅ Preview: https://jupyterlite-git-fork-bollwyvl-update-dx-jtpx.vercel.app

@bollwyvl
Copy link
Collaborator Author

Yeah, just overloading IWindowResolver wasn't sufficient... i'd be inclined to keep what's in now (maybe add a comment/link to #22) and call it a win...

@jtpio
Copy link
Member

jtpio commented Apr 17, 2021

Maybe @jupyterlab/application-extension:main could also be disabled then. But I guess it's so also ok to have it fail hard so at least it's visible.

Because of this we lose some of the application commands such as "Close All Other Tabs". But it's fine and should be back when updating to the next 3.1 alpha packages.

app/classic/edit/index.html Outdated Show resolved Hide resolved
app/classic/index.html Outdated Show resolved Hide resolved
app/classic/edit/index.html Outdated Show resolved Hide resolved
restore-keys: |
${{ env.CACHE_EPOCH }}-yarn-packages-
- name: Install
if: steps.cache-node-modules.outputs.cache-hit != 'true'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had forgotten this one to get the actual benefit of caching... knocks a minute off the runtime.

@jtpio
Copy link
Member

jtpio commented Apr 17, 2021

Thanks a lot @bollwyvl, this is great!

@jtpio jtpio merged commit 6c4a7d0 into jupyterlite:main Apr 17, 2021
@jtpio jtpio added this to the 0.1.0 milestone Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants