-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer experience #48
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jtpx/jupyterlite/J8x8Zj7dEiStaJnrhFoSamdk9TTw |
Yeah, just overloading IWindowResolver wasn't sufficient... i'd be inclined to keep what's in now (maybe add a comment/link to #22) and call it a win... |
Maybe Because of this we lose some of the application commands such as "Close All Other Tabs". But it's fine and should be back when updating to the next 3.1 alpha packages. |
… up some binder stuff
restore-keys: | | ||
${{ env.CACHE_EPOCH }}-yarn-packages- | ||
- name: Install | ||
if: steps.cache-node-modules.outputs.cache-hit != 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had forgotten this one to get the actual benefit of caching... knocks a minute off the runtime.
Thanks a lot @bollwyvl, this is great! |
Hooray jupyterlite! I'm excited to start digging into #41 (and in turn getting others excited), but there's a fair amount of "read the source" right now, which is fine! While digging into it, I found a fair number of things that could be quickly updated to improve the developer "curb appeal", and pave the way for more contribution.
Of course, if any of these things aren't fun, we can take them out, split them up, whatever!
watch
build
intobuild:lib
andbuild:app
prettier
quieterserve
(appears broken for me) andserve:py
(used in proxy).yarn-packages
for local mirroringmetapackage
always tries to redirect todoc/workspaces/auto-X?reset
apputils-extension:resolver
, seems to do the thing, not sure what side-effects this may have, but workspaces deserve special consideration, anyway...pyodide kernels diewindow.location
the kernels all seem to fail, and thrash against the (non-existent) endpointnode_modules
and.yarn-packages
caching to workflow