Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VegaLite MimeDocument mutates model #8732

Open
ellisonbg opened this issue Jul 27, 2020 · 0 comments
Open

VegaLite MimeDocument mutates model #8732

ellisonbg opened this issue Jul 27, 2020 · 0 comments
Assignees
Milestone

Comments

@ellisonbg
Copy link
Contributor

Description

JupyerLab allows a user to open a .vl VegaLite file in a text editor and live render at the same time. Editing the text file will update the rendered visualization. However, each render, the text in the text editor gets overwritten, with no identation or formatting.

Expected behavior

Rendered visualization should not mutate the model in the document case.

Root cause

The issue is that the VegaLite MIME renderer calls setData to update the image/png after the visualization is rendered. The MIMEDocument has a handler that is called that triggers the underlying text file to be overwritten. A new argument to setData should be added that causes the mutations to not be persisted to the file. We need to verify that the data is saved in the notebook output case.

@ellisonbg ellisonbg added this to the 3.0 milestone Jul 27, 2020
@ellisonbg ellisonbg self-assigned this Jul 27, 2020
@ellisonbg ellisonbg modified the milestones: 3.0, Future Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant