Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger typographical hierarchy is confusing, Left and Right panel headers end up showing filenames in all caps for certain panels. #14019

Open
andrii-i opened this issue Feb 16, 2023 · 4 comments
Open

Debugger typographical hierarchy is confusing, Left and Right panel headers end up showing filenames in all caps for certain panels. #14019

andrii-i opened this issue Feb 16, 2023 · 4 comments
Labels
bug pkg:debugger tag:Design and UX
Milestone
4.1.x

Comments

@andrii-i
Copy link
Contributor

Description

In Debugger Left and Right panel headers have the same typography as the accordion panel headers below. This makes the typographical hierarchy confusing and also ends up showing filenames in all caps for certain panels

Reproduce

  1. Open debugger
  2. Note typographical inconsistencies

image

Expected behavior

Left and Right panel headers are visually distinct from headers below, filenames are shown as-is without capitalization.

Context

Operating System and version: MacOS 12.6.3
Browser and version: Chrome version 109.0.5414.87 (Official Build) (arm64)
JupyterLab version: head-of-master (WIP 4.0.0)
@andrii-i andrii-i added bug status:Needs Triage Applied to new issues that need triage pkg:debugger labels Feb 16, 2023
@JasonWeill
Copy link
Contributor

The TOC (table of contents) extension also displays its title in ALL CAPS, including capitalizing filenames.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Feb 16, 2023
@JasonWeill
Copy link
Contributor

Alternative, use the title "Debugger" instead of the filename

@krassowski
Copy link
Member

Alternative, use the title "Debugger" instead of the filename

Empty indicator will be needed in this case because debugger may not be enabled in specific notebooks. Currently this is indicated by "-" in place of file name which is not clear enough and users find it confusing (e.g. https://stackoverflow.com/q/75453541/6646912), we could follow blank indicator rules as suggested in #13988 (comment)

@JasonWeill
Copy link
Contributor

If the debugger widget is visible in the panel, its title should be "Debugger" and it should contain a placeholder to indicate that it is unavailable — see #13988 for a similar task on the TOC extension

@JasonWeill JasonWeill mentioned this issue Feb 16, 2023
Closed
@andrii-i andrii-i mentioned this issue Mar 23, 2023
Open
@andrii-i andrii-i added this to the 4.1.0 milestone Apr 25, 2023
@krassowski krassowski modified the milestones: 4.1.0, 4.1.x Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pkg:debugger tag:Design and UX
Projects
None yet
Milestone
4.1.x
Development

No branches or pull requests
3 participants
@krassowski @andrii-i @JasonWeill