New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shfmt pre-commit hook fails on files with spaces in path #102

Open

robert914 opened this issue Mar 18, 2022 · 0 comments

robert914 commented Mar 18, 2022 •

edited

Loading

The shfmt pre-commit hook fails if the file path contains spaces. The issue is that these lines in: https://github.com/jumanjihouse/pre-commit-hooks/blob/master/pre_commit_hooks/shfmt

readonly cmd="shfmt -w $*"
echo "[RUN] ${cmd}"
${cmd}

should probably instead be something like:

readonly cmd=(shfmt "-w" "$@")
echo "[RUN] ${cmd[@]}"
"${cmd[@]}"

To properly handle spaces in paths. Thanks!

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment