Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long success messages can break mid-word #30

Open
ravichandrasekaran opened this issue Sep 27, 2019 · 1 comment
Open

Long success messages can break mid-word #30

ravichandrasekaran opened this issue Sep 27, 2019 · 1 comment

Comments

@ravichandrasekaran
Copy link
Contributor

Long success messages can break mid-word, like this example from Chapter 4, section 11:

Great job! In this case study, you will evaluate this model, plus two kinds of gradient boosting models.

I think one well-placed call to stringr::str_wrap would fix them all (and preserve the emoji's, hopefully), but can't find where to place it, or how to test it.

c4-s11-word-break
@juliasilge
Copy link
Owner

juliasilge commented Sep 29, 2019 •
edited
Loading

Yep, I noticed this as well and hadn't found a way to address it yet.

  • The success messages are all in individual files called test_02_11_2.R and similar, and are here in the repo.
  • The test files get used in this component that generates the code exercises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ravichandrasekaran @juliasilge