Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ports): refactor port service state #18147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(ports): refactor port service state #18147

wants to merge 2 commits into from
+1,383 −937

Commits on Sep 27, 2024

  1. refactor(ports): refactor RunAtomic ports domain 

    The initial implementation of the ports domain included far too much
business logic in the state layer. This was made particularly bad given
the usage of RunAtomic.

Hoist all of this business logic out of the state layer and into the
service layer. Do this by re-writing the domain
    @jack-w-shaw
    jack-w-shaw committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    79a6fe4 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. chore: respond to comments

    @jack-w-shaw
    jack-w-shaw committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3de8817 View commit details
    Browse the repository at this point in the history