feat: remove tags from UserAccess #18132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aflynn50
force-pushed
the
update-useraccess
branch
from
d72cc7e
to
14519e0
Compare
There was a call here getting more info that it needed, it only wanted the user access level. Change it and change the errors it looks for to match.
As part of the effort to remove tags from the domain, remove them from the UserAccess struct and fix all the call sites to generate them if needed.
Aflynn50
force-pushed
the
update-useraccess
branch
from
14519e0
to
41f6ff1
Compare
SimonRichardson
approved these changes
Sep 24, 2024
manadart
approved these changes
Sep 24, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to remove tags from the domain, remove them from
the UserAccess struct and fix all the call sites to generate them if
needed.
As a flyby:
fix: use ReadAccessLevelForTarget
There was a call getting more info that it needed, it only wanted
the user access level. Change it and change the errors it looks for to
match.
Checklist
QA steps
Links
Jira card: JUJU-5416