fix(application): caas model application status to respect equivalent severity #17699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 similar comments
|
/build |
carlcsaposs-canonical
force-pushed
the
waiting-status-override-bug-2038833
branch
from
38e5ff3
to
257f4f2
Compare
|
(force pushed to fix commit message body line length so that https://github.com/juju/juju/actions/runs/9870702234/job/27292022823#step:4:17 passes) |
wallyworld
approved these changes
Sep 18, 2024
|
/build |
|
@carlcsaposs-canonical thanks for the fix, are you able to sign your commit? That's now a requirement. |
… severity When selecting between operator and application statuses with the same severity level (e.g. both waiting) on a caas model Juju selects the operator status instead of the application status, which is likely more relevant, as reported by https://bugs.launchpad.net/juju/+bug/2038833/comments/2 Builds on the changes in PR #17572
carlcsaposs-canonical
force-pushed
the
waiting-status-override-bug-2038833
branch
from
257f4f2
to
93b6436
Compare
|
hi @wallyworld! I believe the commit is now signed |
|
/build |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting between operator and application statuses with the same severity level (e.g. both waiting) on a caas model Juju selects the operator status instead of the application status, which is likely more relevant, as reported by https://bugs.launchpad.net/juju/+bug/2038833/comments/2
Builds on the changes in PR #17572
Checklist
[ ] Integration tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
Using the reproducer in the error report:
Actual behavior (without this change) "bar" app status flickers between waiting status "installing agent" and waiting status "upgrading unit ..."
Expected behavior (with this change) "bar" app status stays at waiting status "upgrading unit ..."
Links
Launchpad bug: https://bugs.launchpad.net/juju/+bug/2038833/comments/2