Skip to content

Commit

Permalink
Shorten comments re:attach() for CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuaulrich committed Apr 6, 2023
1 parent 6850113 commit 95c7ede
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions CRAN_comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
Regarding the NOTE about the calls to attach():
The calls to attach() are made in the function attachSymbols(). This function is a mechanism to wrap the complexity of attaching multiple symbols (a database of potentially thousands of individual instrument names) with one simple call. Based on previous emails with CRAN regarding this specific attach usage, and the lack of anything beyond the NOTE 'finding' the call, this seems well within the scope of behavior required by CRAN. Note that the name of the function doing this attach is an extension of the attach name itself, which makes the function's purpose clear.

Regarding the NOTE about the calls to attach(): They are made in the function attachSymbols(), which allows users to attach multiple symbols (potentially thousands) from a database with only one function call. Note that the name of the function makes it clear that it provides functionality similar to attach(). Prior emails with the CRAN team approved of this specific use of attach().

0 comments on commit 95c7ede

Please sign in to comment.