Add comments for recently made public classes do not match contract

* Add comments to explain why the classes are made public, but not on contract
joshfree · May 20, 2016 · a60182b · a60182b
1 parent 0303d71
commit a60182b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/MessageFault.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/MessageFault.cs
@@ -396,6 +396,9 @@ private void WriteTo11(XmlDictionaryWriter writer)
         }
     }
 
+    /*
+    This class is not exposed on the contract as we only need it public for reflection purpose on .Net Native.
+    */
     public class XmlObjectSerializerFault : MessageFault
     {
         private FaultCode _code;

diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/FaultFormatter.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/FaultFormatter.cs
@@ -11,6 +11,9 @@
 
 namespace System.ServiceModel.Dispatcher
 {
+     /*
+      This class is not exposed on the contract as we only need it public for reflection purpose on .Net Native.
+      */
     public class FaultFormatter : IClientFaultFormatter, IDispatchFaultFormatter
     {
         private FaultContractInfo[] _faultContractInfos;
@@ -193,6 +196,9 @@ private static MessageFault CreateMessageFault(XmlObjectSerializer serializer, F
             return (MessageFault)Activator.CreateInstance(operationFaultType, serializer, faultException);
         }
 
+        /*
+        This class is not exposed on the contract as we only need it public for reflection purpose on .Net Native.
+        */
         public class OperationFault<T> : XmlObjectSerializerFault
         {
             public OperationFault(XmlObjectSerializer serializer, FaultException<T> faultException) :
-Original file line number
+Diff line change
@@ Expand Up / @@ -396,6 +396,9 @@ private void WriteTo11(XmlDictionaryWriter writer) @@
             }
         }
+        /*
+        This class is not exposed on the contract as we only need it public for reflection purpose on .Net Native.
+        */
         public class XmlObjectSerializerFault : MessageFault
         {
             private FaultCode _code;
@@ Expand Down @@