Make OperationFault public so that we are able to reflect it

* We are currently unable to reflect OperationFault. The least risk option is to make it public. * In order to make it public, we need to make FaultFormatter and XmlObjectSerializerFault public as well. Fix dotnet#769
joshfree · May 19, 2016 · 94894d5 · 94894d5
1 parent bda9d9e
commit 94894d5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/MessageFault.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/MessageFault.cs
@@ -396,7 +396,7 @@ private void WriteTo11(XmlDictionaryWriter writer)
         }
     }
 
-    internal class XmlObjectSerializerFault : MessageFault
+    public class XmlObjectSerializerFault : MessageFault
     {
         private FaultCode _code;
         private FaultReason _reason;

diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/FaultFormatter.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/FaultFormatter.cs
@@ -11,7 +11,7 @@
 
 namespace System.ServiceModel.Dispatcher
 {
-    internal class FaultFormatter : IClientFaultFormatter, IDispatchFaultFormatter
+    public class FaultFormatter : IClientFaultFormatter, IDispatchFaultFormatter
     {
         private FaultContractInfo[] _faultContractInfos;
 
@@ -193,7 +193,7 @@ private static MessageFault CreateMessageFault(XmlObjectSerializer serializer, F
             return (MessageFault)Activator.CreateInstance(operationFaultType, serializer, faultException);
         }
 
-        internal class OperationFault<T> : XmlObjectSerializerFault
+        public class OperationFault<T> : XmlObjectSerializerFault
         {
             public OperationFault(XmlObjectSerializer serializer, FaultException<T> faultException) :
                 base(faultException.Code, faultException.Reason,

diff --git a/....Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.cs b/....Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.cs
@@ -188,9 +188,6 @@ public static void UnknownUrl_Throws_ProtocolException()
     }
 
     [Fact]
-#if FEATURE_NETNATIVE
-    [ActiveIssue(769)] // Blocked from working in NET Native due to a toolchain issue.
-#endif
     [OuterLoop]
     public static void DuplexCallback_Throws_FaultException_DirectThrow()
     {
@@ -236,9 +233,6 @@ public static void DuplexCallback_Throws_FaultException_DirectThrow()
     }
 
     [Fact]
-#if FEATURE_NETNATIVE
-    [ActiveIssue(769)] // Blocked from working in NET Native due to a toolchain issue.
-#endif
     [OuterLoop]
     public static void DuplexCallback_Throws_FaultException_ReturnsFaultedTask()
     {