comment to rethink the map reference for the notifier discovery

josedonizetti · Jan 16, 2018 · 8369826 · 8369826
1 parent 2e058b1
commit 8369826
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/cmd/prometheus/main.go b/cmd/prometheus/main.go
@@ -296,6 +296,7 @@ func main() {
 			c := make(map[string]sd_config.ServiceDiscoveryConfig)
 			for _, v := range cfg.AlertingConfig.AlertmanagerConfigs {
 				// AlertmanagerConfigs doesn't hold an unique identifier so we use the config pointer as the identifier.
+				// TODO Krasi - Maybe use the slice index as the reference.
 				c[fmt.Sprintf("%p", v)] = v.ServiceDiscoveryConfig
 			}
 			return discoveryManagerNotify.ApplyConfig(c)

diff --git a/notifier/notifier.go b/notifier/notifier.go
@@ -257,6 +257,7 @@ func (n *Notifier) ApplyConfig(conf *config.Config) error {
 		ams.metrics = n.metrics
 
 		// The config pointer is used for the map lookup identifier.
+		// TODO Krasi - Maybe use the slice index as the reference.
 		amSets[fmt.Sprintf("%p", cfg)] = ams
 	}