Fix deserializer for SvgPreviewView

josa42 · Dec 30, 2016 · b5afea9 · b5afea9
1 parent 0cbabd8
commit b5afea9
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 0.10.2
+- Fix bugs related to not properly deactivating the package.
+
 ## 0.10.1
 - Fix zoom reset on save
 

diff --git a/lib/main.js b/lib/main.js
@@ -5,37 +5,36 @@ import url from 'url'
 
 let SvgPreviewView = null
 
-function createSvgPreviewView(state) {
+function importSvgPreviewView() {
   if (SvgPreviewView == null) {
     SvgPreviewView = require('./svg-preview-view')
   }
+}
+
+function createSvgPreviewView(state) {
+  importSvgPreviewView()
   return new SvgPreviewView(state)
 }
 
 function isSvgPreviewView(object) {
-  if (SvgPreviewView == null) {
-    SvgPreviewView = require('./svg-preview-view')
-  }
+  importSvgPreviewView()
   return object instanceof SvgPreviewView
 }
 
 function configGet(key) {
   return atom.config.get(`svg-preview.${key}`)
 }
 
-atom.deserializers.add({
-  name: 'SvgPreviewView',
-  deserialize(state) {
-    if (state.constructor === Object) {
-      return createSvgPreviewView(state)
-    }
-  }
-})
-
 module.exports = {
 
   config: require('./config'),
 
+  deserializeSvgPreviewView(state) {
+    if (state.constructor === Object) {
+      return createSvgPreviewView(state)
+    }
+  },
+
   activate() {
     this.disposables = new CompositeDisposable
 

diff --git a/package.json b/package.json
@@ -22,5 +22,8 @@
   "devDependencies": {
     "temp": "^0.8.3",
     "wrench": "^1.5.9"
+  },
+  "deserializers": {
+    "SvgPreviewView": "deserializeSvgPreviewView"
   }
 }