Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYI: a clone of word-wrap now exists #43

Closed
sawilde opened this issue Jul 19, 2023 · 2 comments
Closed

FYI: a clone of word-wrap now exists #43

sawilde opened this issue Jul 19, 2023 · 2 comments

Comments

@sawilde
Copy link

sawilde commented Jul 19, 2023 •
edited
Loading

I see that this clone package of word-wrap has since replaced word-wrap in a number of repositories.

It looks like they went straight to trimEnd to fix the ReDOS issue.
@sawilde sawilde changed the title a clone of word-wrap now exists FYI: a clone of word-wrap now exists Jul 19, 2023
@wellwelwel
Copy link

wellwelwel commented Jul 19, 2023 •
edited
Loading

Hi @sawilde, I suggested this fork for some repositories as a provisional measure until it was properly fixed here (the original project), particularly for optionator (a direct dependency for ESLint and escodegen, for example) as seen in:

I think that if this problem has been solved (#33 and #41), we can safely return to the original word-wrap project 🎉

And, thanks @doowb 🙋🏻‍♂️

@wellwelwel wellwelwel mentioned this issue Jul 19, 2023
Closed
@sawilde
Copy link
Author

sawilde commented Jul 19, 2023

Nice, that was how I came across it when I looked to upgrade word-wrap and noticed the eslint dependency.

@sawilde sawilde closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sawilde @wellwelwel